Change philox state API usage to support XPU graph #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the XPU implementation to use the new philox_xpu_state API instead of the legacy philox_engine_inputs API to support XPU graph functionality. The changes replace the old pair-based approach for Philox random number generation with a unified state object.
- Replace
philox_engine_inputs()calls withphilox_xpu_state() - Update function signatures to use
PhiloxXpuStateinstead ofstd::pair<uint64_t, uint64_t> - Replace
philox_unpack()withat::xpu::philox::unpack()
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/RreluWithNoiseKernels.cpp | Updates RReLU with noise kernel to use new philox state API |
| src/ATen/native/xpu/sycl/RandpermKernel.cpp | Updates randperm kernel to use new philox state API and removes unused include |
| src/ATen/native/xpu/sycl/MultinomialKernel.cpp | Updates multinomial kernel to use new philox state API |
| src/ATen/native/xpu/sycl/Dropout.cpp | Updates dropout kernels to use new philox state API |
| src/ATen/native/xpu/sycl/Distributions.cpp | Updates various distribution kernels to use new philox state API |
| src/ATen/native/xpu/sycl/DistributionTemplates.h | Removes PhiloxState definition and updates template functions to use new API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Ma, Jing1 <[email protected]>
majing921201
changed the title
|
I assume the existing cases already cover this change, right? @majing921201 |
gujinghui
approved these changes
Oct 17, 2025
yes |
guangyey
approved these changes
Oct 17, 2025
|
Try to land... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch philox_engine_inputs usage to philox_xpu_state per XPU graph request. This PR requires stock pytorch XPUGeneratorImpl PR merged.